Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xarray upper bound to avoid v2024.02.0 #108

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Feb 19, 2024

After the latest xarray release errors started appearing in the CI. See, for example, https://github.com/COSIMA/regional-mom6/actions/runs/7957078139/job/21719091616#step:7:226

See pydata/xarray#8769

Adding an upper bound in pyproject to preclude the xarray v2024.02.0 resolves the issue for now until a patch release comes out from xarray.

@navidcy navidcy added bug 🐞 Something isn't working package 📦 labels Feb 19, 2024
@navidcy navidcy requested a review from angus-g February 19, 2024 09:27
@navidcy navidcy changed the title Add xarray upper bound Add xarray upper bound to avoid v2024.02.0 Feb 19, 2024
@angus-g
Copy link
Collaborator

angus-g commented Feb 19, 2024

The root of this is xESMF needing to upgrade to look for is_dask_collection in xarray.core.utils not xarray.core.pycompat (pangeo-data/xESMF#338)

@navidcy
Copy link
Contributor Author

navidcy commented Feb 19, 2024

oh I see! is there a better solution than adding a compat entry for xarray?

@navidcy
Copy link
Contributor Author

navidcy commented Feb 19, 2024

If you can comment on the issue I opened in xarray it might be helpful. Perhaps that needs to close then..

@angus-g
Copy link
Collaborator

angus-g commented Feb 19, 2024

is there a better solution than adding a compat entry for xarray?

No, I think this is still the way to go.

@navidcy
Copy link
Contributor Author

navidcy commented Feb 19, 2024

is there a better solution than adding a compat entry for xarray?

No, I think this is still the way to go.

OK, cool!

@angus-g
Copy link
Collaborator

angus-g commented Feb 19, 2024

But I wonder if there's a way to remind us to unpin when there's a new xESMF release...

@navidcy
Copy link
Contributor Author

navidcy commented Feb 19, 2024

you hope that because we mentioned the xESMF issue we'll now get notifications when things update there and we'll see when it's resolved, right?

@navidcy
Copy link
Contributor Author

navidcy commented Feb 19, 2024

I actually subscribed to the issue to make sure.

@navidcy
Copy link
Contributor Author

navidcy commented Feb 19, 2024

Shall we merge this you reckon?

Copy link
Collaborator

@angus-g angus-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let's go with this for now.

@angus-g angus-g merged commit c51c66b into main Feb 19, 2024
4 checks passed
@angus-g angus-g deleted the ncc/xarray-compat branch February 19, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working package 📦
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants