-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xarray
upper bound to avoid v2024.02.0
#108
Conversation
xarray
upper boundxarray
upper bound to avoid v2024.02.0
The root of this is xESMF needing to upgrade to look for |
oh I see! is there a better solution than adding a compat entry for xarray? |
If you can comment on the issue I opened in xarray it might be helpful. Perhaps that needs to close then.. |
No, I think this is still the way to go. |
OK, cool! |
But I wonder if there's a way to remind us to unpin when there's a new xESMF release... |
you hope that because we mentioned the xESMF issue we'll now get notifications when things update there and we'll see when it's resolved, right? |
I actually subscribed to the issue to make sure. |
Shall we merge this you reckon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, let's go with this for now.
After the latest xarray release errors started appearing in the CI. See, for example, https://github.com/COSIMA/regional-mom6/actions/runs/7957078139/job/21719091616#step:7:226
See pydata/xarray#8769
Adding an upper bound in
pyproject
to preclude the xarray v2024.02.0 resolves the issue for now until a patch release comes out from xarray.